fix: subpath bad matching #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 82.66% 82.59% -0.07%
==========================================
Files 27 27
Lines 3242 3241 -1
Branches 671 672 +1
==========================================
- Hits 2680 2677 -3
- Misses 344 345 +1
- Partials 218 219 +1
☔ View full report in Codecov by Sentry. |
Any base path matched by a subpath with a different root will also return the nodes of the subpath (which is obviously erroneous)
Mocramis
force-pushed
the
subpath_bad_matching
branch
from
f4bc029
to
f1e651e
Compare
Mocramis
force-pushed
the
subpath_bad_matching
branch
from
f1e651e
to
9107ff1
Compare
|
Hmm i'm not sure what Codecov means by "Consider uploading the report" |
|
I think this change is fine. I would like Mike to take a look at it though since it has potential impact to supervisor |
Any news ? |
|
I chatted with Mike about this earlier this week. He hasn't had time to test it yet |
|
any updates ? |
bdraco
approved these changes
Aug 17, 2023
|
This LGTM. I can't see this causing a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although uncommon, i saw nothing in the dbus spec forbidding sub-path matching possible parent paths.
Current implementation of Introspect assumes this is the case though resulting in path being presented where they are not for instance instrospect on
/areturning subnodesbanddwhen the registered paths are/a/band/c/a/dThis mr tests and fixes the issue.
Note: a more efficient way to fix would have been to use str.removeprefix but it is only available from python3.9.